chore: make fields/developerFields n buffer size 255 instead of 256 #303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muktihari
added
the
chore
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #303 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 42 42
Lines 3691 3691
=========================================
Hits 3691 3691 ☔ View full report in Codecov by Sentry. |
muktihari
deleted the
chore/make-fields-developer-fields-n-size-255-instead-of-256
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A byte value is between 0-255, so
field's num,n Fieldsandfield's value sizemax value is 255. The same logic applies for developer fields as well. So we only need 255 size for those values such as when creatingfieldsArrayin decoder, fields'poolin mesgdef, etc. Even the maximum number of character in a string should not exceed 255.And for
factory, we keep the fields' size 256 as we want to ensure O(1) field lookup, and technically, field number 255 is still a valid byte even if it's an invalid field number.